Fixing an issue where a Python library is not recognized in the portable version by start-life · Pull Request #1080 · ace-step/ACE-Step-1.5

start-life · 2026-04-09T16:41:07Z

Fixing an issue where a Python library is not recognized in the portable version
There is a typo of python_embedded instead of python_embeded, it's actually an extra letter d.
I fixed it. Please note that there may be additional errors. Fix this throughout the code.

Summary by CodeRabbit

Documentation
- Updated installation guide with corrected embedded Python directory structure references
Chores
- Synchronized embedded Python directory path references across all startup scripts and testing utilities to ensure consistent environment detection and accurate user guidance

Corrected the spelling of 'python_embedded' to 'python_embeded' in the installation instructions.

coderabbitai · 2026-04-09T16:41:24Z

📝 Walkthrough

Walkthrough

This PR updates references to an embedded Python directory across documentation and multiple startup/test scripts, changing the expected directory name from python_embedded to python_embeded in path detection logic and user-facing messages.

Changes

Cohort / File(s)	Summary
Documentation `docs/en/INSTALL.md`	Updated portable package documentation to reference `python_embeded` instead of `python_embedded`, including environment detection priority list.
Startup Scripts (Batch) `start_api_server.bat`, `start_gradio_ui.bat`, `start_gradio_ui_manual.bat`	Updated embedded Python detection paths and user-facing error messages from `python_embedded` to `python_embeded`.
Startup Scripts (macOS) `start_api_server_macos.sh`, `start_gradio_ui_macos.sh`	Updated embedded Python auto-detection, permission operations, validation, and log messages to reference `python_embeded` instead of `python_embedded`.
Test Scripts `quick_test.bat`, `test_env_detection.bat`	Updated environment detection and selection logic to check for and reference `python_embeded\python.exe` instead of `python_embedded\python.exe`, including test messages and result output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Fix spelling errors across codebase #786: Changes the same embedded-Python directory name across identical scripts/docs; direct code-level conflict or related refactor.

Suggested reviewers

ChuxiJ

Poem

🐰 A bunny hops through scripts with glee,
Renaming paths for all to see,
From "embedded" to "embeded" we go,
Consistency blooms—a helpful show! 🌿✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Fixing an issue where a Python library is not recognized in the portable version' accurately describes the main change: correcting the misspelled directory name 'python_embedded' to 'python_embeded' across multiple scripts and documentation files that affect Python library recognition in portable builds.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

start_gradio_ui_macos.sh (1)
237-257: ⚠️ Potential issue | 🟡 Minor

Update the nearby stale python_embedded comments too.

The path rename in this block is correct, but the adjacent comments on Line 236 and Line 256 still mention python_embedded. That leaves this file inconsistent with the new directory name and makes future maintenance/grep-based cleanup harder.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@start_gradio_ui_macos.sh` around lines 237 - 257, The comments adjacent to
the embeded-Python block still reference the old name "python_embedded" and need
to be updated to match the actual path/name used in the script
(SCRIPT_DIR/python_embeded) to avoid inconsistency; search the block around
SCRIPT_DIR/python_embeded and the usage of python3.11 / PYTHON_EXE / SCRIPT_PATH
and replace any comment text mentioning "python_embedded" with "python_embeded"
(or rephrase to "embedded Python (python_embeded)") so comments accurately
reflect the actual directory name and the code.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@start_gradio_ui_macos.sh`:
- Around line 237-257: The comments adjacent to the embeded-Python block still
reference the old name "python_embedded" and need to be updated to match the
actual path/name used in the script (SCRIPT_DIR/python_embeded) to avoid
inconsistency; search the block around SCRIPT_DIR/python_embeded and the usage
of python3.11 / PYTHON_EXE / SCRIPT_PATH and replace any comment text mentioning
"python_embedded" with "python_embeded" (or rephrase to "embedded Python
(python_embeded)") so comments accurately reflect the actual directory name and
the code.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6008d48a-fcfa-485d-8ee3-a885bfa082c0

📥 Commits

Reviewing files that changed from the base of the PR and between 82252c2 and b8785af.

📒 Files selected for processing (8)

docs/en/INSTALL.md
quick_test.bat
start_api_server.bat
start_api_server_macos.sh
start_gradio_ui.bat
start_gradio_ui_macos.sh
start_gradio_ui_manual.bat
test_env_detection.bat

start-life added 10 commits April 9, 2026 19:20

Fix typo in python embedded directory name

bd22693

Fix typo in embedded Python directory name

960528e

Fix typo in embedded Python directory name

1a7916e

Fix typo in embedded Python directory name

ef27af0

Fix typo in INSTALL.md for Windows package instructions

0ef99ea

Corrected the spelling of 'python_embedded' to 'python_embeded' in the installation instructions.

Update start_api_server_macos.sh

452b1da

Update start_api_server_macos.sh

dd4e2b8

Fix typo in python_embedded to python_embeded

a125c48

Fix typo in error message for package detection

9e23b9b

Fix typo in python_embedded to python_embeded

b8785af

coderabbitai Bot reviewed Apr 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing an issue where a Python library is not recognized in the portable version#1080

Fixing an issue where a Python library is not recognized in the portable version#1080
start-life wants to merge 10 commits intoace-step:mainfrom
start-life:main

start-life commented Apr 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 9, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

start-life commented Apr 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

start-life commented Apr 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 9, 2026 •

edited

Loading